Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add webtransport listener #2422

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Feb 23, 2024

Adds a transport listener to @libp2p/webtransport for Node.js

In draft for now, there's some very strange behaviour around closing stream writers in browsers.

A lot has changed with @fails-components/webtransport since we last looked at it.

Notably it's been rewritten internally and no longer uses it's own event loop which is a marked improvement on the user experience.

Unfortunately some tests that were passing before now fail so there's some investigation to do.

Refs #2371

TODO:

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

Adds a transport listener to `@libp2p/webtransport` for Node.js
achingbrain added a commit that referenced this pull request May 1, 2024
The PR pulls all of the non-`@fails/webtransport` parts out of #2422

There's a lot of work that's been done to re-use existing libp2p
code such as the abstract stream class which handles a lot more
closing scenarios than the existing implementation so it would be
good to get that in.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🧱Blocked
Development

Successfully merging this pull request may close these issues.

1 participant